Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2651]Update the unchecked error for make lint warnings #850

Closed
wants to merge 10 commits into from

Update AddSchedulingEventHandlers to propagate the error back

30f7429
Select commit
Loading
Failed to load commit list.
Closed

[YUNIKORN-2651]Update the unchecked error for make lint warnings #850

Update AddSchedulingEventHandlers to propagate the error back
30f7429
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jun 4, 2024 in 0s

66.95% (-0.38%) compared to 5f80f49

View this Pull Request on Codecov

66.95% (-0.38%) compared to 5f80f49

Details

Codecov Report

Attention: Patch coverage is 20.31250% with 51 lines in your changes missing coverage. Please review.

Project coverage is 66.95%. Comparing base (5f80f49) to head (30f7429).
Report is 4 commits behind head on master.

❗ Current head 30f7429 differs from pull request most recent head e6b78bb

Please upload reports for the commit e6b78bb to get more accurate results.

Files Patch % Lines
pkg/client/apifactory.go 0.00% 16 Missing ⚠️
pkg/cache/context.go 38.88% 6 Missing and 5 partials ⚠️
pkg/cmd/admissioncontroller/main.go 0.00% 11 Missing ⚠️
pkg/admission/conf/am_conf.go 0.00% 5 Missing ⚠️
pkg/admission/priority_class_cache.go 50.00% 2 Missing and 1 partial ⚠️
pkg/client/apifactory_mock.go 0.00% 3 Missing ⚠️
pkg/admission/namespace_cache.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #850      +/-   ##
==========================================
- Coverage   67.33%   66.95%   -0.38%     
==========================================
  Files          70       70              
  Lines        7598     7635      +37     
==========================================
- Hits         5116     5112       -4     
- Misses       2271     2303      +32     
- Partials      211      220       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov