[YUNIKORN-2650]Complete or remove web_server_test#TestProxy #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chia7712
reviewed
May 31, 2024
pkg/webtest/web_server_test.go
Outdated
| @@ -80,5 +80,43 @@ func TestWebServer(t *testing.T) { | |||
| } | |||
|
|
|||
| func TestProxy(t *testing.T) { | |||
| mux := http.NewServeMux() | |||
There was a problem hiding this comment.
This test case is duplicate to TestWebServer, so I prefer to remove TestProxy instead of having many duplicate code. WDYT?
There was a problem hiding this comment.
Sure, I think we can remove TestProxy. No problem, I'll make this change.
|
@0lai0 please fix the linter warning. |
|
Test failure is unrelated. |
|
"make test" & "make lint" passed locally, will merge soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR completes web_server_test#TestProxy.
What type of PR is it?
Todos
What is the Jira issue?
[YUNIKORN-2650]
How should this be tested?
It has been checked locally by make test.
Screenshots (if appropriate)
N/A
Questions:
N/A