Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2319] cache.Task: reference to old pod object is kept after update #864

Closed
wants to merge 3 commits into from

Conversation

pbacsko
Copy link
Contributor

@pbacsko pbacsko commented Jun 27, 2024

What is this PR for?

Whenever a pod is updated, then replace it inside the Task as well so that the previous version can be garbage collected.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2319

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@pbacsko pbacsko self-assigned this Jun 27, 2024
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.43%. Comparing base (18c9985) to head (f2e5798).

Files Patch % Lines
pkg/cache/context.go 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #864      +/-   ##
==========================================
+ Coverage   67.38%   67.43%   +0.04%     
==========================================
  Files          70       70              
  Lines        7623     7633      +10     
==========================================
+ Hits         5137     5147      +10     
  Misses       2268     2268              
  Partials      218      218              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pbacsko pbacsko marked this pull request as draft June 27, 2024 21:03
pkg/cache/context.go Outdated Show resolved Hide resolved
pkg/cache/context.go Outdated Show resolved Hide resolved
@pbacsko pbacsko marked this pull request as ready for review June 28, 2024 07:34
@pbacsko pbacsko requested a review from wilfred-s July 22, 2024 09:19
@pbacsko
Copy link
Contributor Author

pbacsko commented Jul 29, 2024

@wilfred-s could you review this chage?

Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM.

@pbacsko pbacsko closed this in 26443bc Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants