Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2667] E2E test for Gang app originator pod changes after restart #865

Closed
wants to merge 8 commits into from

Conversation

blueBlue0102
Copy link
Contributor

What is this PR for?

Add an E2E test to verify the Gang app originator pod changes after a restart.
Related to #855

What type of PR is it?

  • - Improvement

What is the Jira issue?

YUNIKORN-2667

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.24%. Comparing base (085edca) to head (9c6b7f4).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #865      +/-   ##
==========================================
- Coverage   67.28%   67.24%   -0.04%     
==========================================
  Files          70       70              
  Lines        7609     7609              
==========================================
- Hits         5120     5117       -3     
- Misses       2271     2273       +2     
- Partials      218      219       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chenyulin0719 chenyulin0719 self-requested a review July 2, 2024 17:35
@chenyulin0719
Copy link
Contributor

Hi @blueBlue0102,
As we discussed offline, there is currently no way to check whether an allocation is the originator.
I think it's a good chance to expose the IsOriginator flag in REST.
I've created a Jira and assinged it to you.

@blueBlue0102 blueBlue0102 marked this pull request as ready for review July 6, 2024 15:52
Copy link
Contributor

@chenyulin0719 chenyulin0719 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM, waiting for E2E test pass.

@chenyulin0719 chenyulin0719 requested a review from manirajv06 July 8, 2024 16:15
@blueBlue0102
Copy link
Contributor Author

The reason one of the E2E tests failed is due to a timeout error:
curl: (28) Failed to connect to archive.apache.org port 443 after 133360 ms: Connection timed out
@chenyulin0719 Could you please re-run the E2E test? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants