[YUNIKORN-2540] Deduplicate constants in pkg/cache/context_test.go

[SophieTech88]

What is this PR for?

Constants are duplicated in the pkg/cache/context_test.go
Move to a central point of defining the constants for the test at the top of the file.
The related constant variables as below:

const (

Host1 = "host0001"
Host2 = "host0002"

appID1       = "app00001"
appID2       = "app00002"
appID3       = "app00003"
appID4       = "app00004"
appID5       = "app00005"
appIDUnknown = "app-none-exist"

uid1       = "uid_0001"
uid2       = "uid_0002"
uid3       = "uid_0003"
uid4       = "uid_0004"
uid5       = "uid_0005"
uidUnknown = "uid_0000"

pod1UID     = "task00001"
pod2UID     = "task00002"
taskUID1    = "task00001"
taskUID2    = "task00002"
taskUID3    = "task00003"
taskUID4    = "task00004"
taskUnknown = "non_existing_taskID"

podName1     = "pod1"
podName2     = "pod2"
podName3     = "pod3"
podName4     = "pod4"
podNamespace = "yk"

nodeName1    = "node1"
nodeName2    = "node2"
fakeNodeName = "fake-node"

queueNameA       = "root.a"
queueNameB       = "root.b"
queueNameC       = "root.c"
queueNameUnknown = "root.other"

annoAppID1 = "yunikorn-test-00001"
annoAppID2 = "yunikorn-test-00002"
annoAppID3 = "yunikorn-test-00003"
annoAppID4 = "yunikorn-test-00004"
annoAppID5 = "yunikorn-test-00005"

APIVersion1 = "v1"
testUser    = "test-user"

)

What type of PR is it?

• - Bug Fix
• - Improvement
• - Feature
• - Documentation
• - Hot Fix
• - Refactoring

Todos

• - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2540

How should this be tested?

It should pass all test cases.

Screenshots (if appropriate)

Questions:

• - The licenses files need update.
• - There is breaking changes for older versions.
• - It needs documentation.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.30%. Comparing base (18c9985) to head (0844cdb).
Report is 6 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #866      +/-   ##
==========================================
- Coverage   67.38%   67.30%   -0.09%     
==========================================
  Files          70       70              
  Lines        7623     7625       +2     
==========================================
- Hits         5137     5132       -5     
- Misses       2268     2274       +6     
- Partials      218      219       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[SophieTech88]

I made a e2e test locally, script as : "./scripts/run-e2e-tests.sh -a test -n yktest -v kindest/node:v1.28.0" or "./scripts/run-e2e-tests.sh -a test -n yktest -v kindest/node:v1.30.0", both failed with preemption.

check the error for preemption in detail:

[chenyulin0719]

A minor suggestion.

[pbacsko]

Simplifications are possible and some consistency-related stuff. See comments.

[pbacsko]

@SophieTech88 please rebase your branch with master changes.

[pbacsko]

Actually never mind, I did myself so we can have a green build.

[SophieTech88]

Actually never mind, I did myself so we can have a green build.

Many thanks for your help.

[chenyulin0719]

Thanks @SophieTech88 for the update. A few minor comments.

[chenyulin0719]

+1 LGTM, will merge it once E2E test pass.