[YUNIKORN-2715] Handle special characters for params like queue, user… #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manirajv06
requested review from
FrankYang0529,
chia7712,
wilfred-s,
craigcondit and
pbacsko
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #867 +/- ##
=======================================
Coverage 67.36% 67.36%
=======================================
Files 70 70
Lines 7623 7623
=======================================
Hits 5135 5135
+ Misses 2270 2269 -1
- Partials 218 219 +1 ☔ View full report in Codecov by Sentry. |
|
@pbacsko Can you take a look? E2E test failure is not related to this pr. |
|
@manirajv06 could you temporarily disable the failing tests until the problem is resolved? We've been having failed builds for a good week now. Just like I did with YUNIKORN-2668 |
|
@pbacsko can you take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…name & groupname
What is this PR for?
QueueName, UserName and GroupName may contain special characters which need to be escaped before hitting the url. Added the tests to verify this behaviour.
What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2715
How should this be tested?
Screenshots (if appropriate)
Questions: