[YUNIKORN-2711] Skip setting the queue name to default queue in the shim

[mitdesai]

What is this PR for?

This change removes setting the default queue name from the admission controller. Instead default queue will be decided at the time of placement. (YUNIKORN-2703)

What type of PR is it?

• - Bug Fix
• - Improvement
• - Feature
• - Documentation
• - Hot Fix
• - Refactoring

Todos

• - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2711

How should this be tested?

Screenshots (if appropriate)

Questions:

• - The licenses files need update.
• - There is breaking changes for older versions.
• - It needs documentation.

[mitdesai]

Related core changes to try and place the application in root.default are here: apache/yunikorn-core#904

This change does take away the configuration for setting a custom default queue where the applications will be placed if no rule matches. This can be achieved by adding a fixed rule at the end of the placement rules with the desired queue name.

for example, if the placement rules are:

placementrules:
- provided
- tag

And the application placement cannot succeed from both these rules, we will try to place the application to place in 'root.default' before rejecting it.

If any other queue is desired as a default queue, we can update the placement rules to:

placementrules:
- provided
- tag
- fixed
  value: root.custom

Here, after provided and tag are unsuccessful, the app will be placed by the fixed rule as long as the acls are valid.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.28%. Comparing base (b337896) to head (231854d).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #874      +/-   ##
==========================================
- Coverage   67.36%   67.28%   -0.08%     
==========================================
  Files          70       70              
  Lines        7623     7609      -14     
==========================================
- Hits         5135     5120      -15     
- Misses       2270     2271       +1     
  Partials      218      218              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[craigcondit]

+1 LGTM.