[YUNIKORN-2713] Use queue specific REST API directly #878
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #878 +/- ##
==========================================
- Coverage 67.30% 67.27% -0.03%
==========================================
Files 70 70
Lines 7625 7625
==========================================
- Hits 5132 5130 -2
- Misses 2274 2276 +2
Partials 219 219 ☔ View full report in Codecov by Sentry. |
| if queueName == "root" { | ||
| return queues, nil | ||
| } | ||
| // Include the query string 'subtree' to retrieve all queue children by default for better convenience in E2E tests |
There was a problem hiding this comment.
why we need this? The Restful API queue/${queue} already returns what you want, right?
There was a problem hiding this comment.
My intention was to make it easier for anyone who might use this utility method in the future. If a test case needs to check the queue's children and finds that this method doesn't retrieve them, it could be confusing, I think.
If this concern is unnecessary, I'm happy to remove this code. Or maybe GetQueue() could have an additional parameter: bool withChildren to remind callers and avoid potential confusion.
There was a problem hiding this comment.
could have an additional parameter: bool withChildren to remind callers and avoid potential confusion.
that is good to me
What is this PR for?
There are some places in e2e tests using old way to fetching all queues for the given partition, then fetch queue specific info in next call. Instead, Queue info can be fetched directly in a single call.
What type of PR is it?
What is the Jira issue?
YUNIKORN-2713