[YUNIKORN-2771] Optimization: Mark placeholder pods for non-graceful termination #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…termination Update the Kubernetes pod spec for placeholder pods to set TerminationGracePeriodSeconds to 0. This allows the pods to be removed immediately when terminated.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #883 +/- ##
==========================================
- Coverage 68.09% 68.07% -0.02%
==========================================
Files 70 70
Lines 7625 7627 +2
==========================================
Hits 5192 5192
- Misses 2216 2217 +1
- Partials 217 218 +1 ☔ View full report in Codecov by Sentry. |
zhuqi-lucas
reviewed
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Update the Kubernetes pod spec for placeholder pods to set TerminationGracePeriodSeconds to 0. This allows the pods to be removed immediately when terminated.
What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2771
How should this be tested?
Screenshots (if appropriate)
Questions: