Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2759] Replace %w by Errors.join #884

Closed
wants to merge 2 commits into from

Conversation

ryankert01
Copy link
Contributor

What is this PR for?

original discussion: https://issues.apache.org/jira/browse/YUNIKORN-2262

Errors.join can make the code more performant and readable

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2759

How should this be tested?

make test

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@ryankert01 ryankert01 marked this pull request as ready for review July 25, 2024 21:47
@pbacsko pbacsko self-requested a review July 26, 2024 07:17
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 68.02%. Comparing base (498b8ea) to head (af698ab).
Report is 1 commits behind head on master.

Files Patch % Lines
pkg/client/apifactory.go 0.00% 2 Missing ⚠️
pkg/admission/conf/am_conf.go 0.00% 1 Missing ⚠️
pkg/admission/namespace_cache.go 0.00% 1 Missing ⚠️
pkg/admission/priority_class_cache.go 0.00% 1 Missing ⚠️
pkg/plugin/predicates/predicate_manager.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #884      +/-   ##
==========================================
- Coverage   68.09%   68.02%   -0.07%     
==========================================
  Files          70       70              
  Lines        7625     7625              
==========================================
- Hits         5192     5187       -5     
- Misses       2216     2220       +4     
- Partials      217      218       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pbacsko pbacsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@pbacsko pbacsko closed this in b947dca Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants