[YUNIKORN-1697] [shim] Make namespace annotation to support max appli… #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhuqi-lucas
requested review from
wilfred-s,
pbacsko,
chenyulin0719 and
craigcondit
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #885 +/- ##
==========================================
+ Coverage 68.09% 68.16% +0.07%
==========================================
Files 70 70
Lines 7625 7642 +17
==========================================
+ Hits 5192 5209 +17
Misses 2216 2216
Partials 217 217 ☔ View full report in Codecov by Sentry. |
| // add maxApps resource info as an app tag | ||
| maxApps := utils.GetNamespaceMaxAppsFromAnnotation(namespaceObj) | ||
| if maxApps != "" { | ||
| request.Metadata.Tags[siCommon.AppTagNamespaceResourceMaxApps] = maxApps |
There was a problem hiding this comment.
The comment of this function should include "namespace.resourcemaxapps". Besides, the "namespace.resourceguaranteed" looks like missing in the previous change.
// update application tags in the AddApplicationRequest based on the namespace annotation
// adds the following tags to the request based on annotations (if exist):
// - namespace.resourcequota
// - namespace.parentqueue
// - namespace.resourceguaranteed
// - namespace.resourcemaxapps
func (ctx *Context) updateApplicationTags(request *AddApplicationRequest, namespace string) {
There was a problem hiding this comment.
Thanks for pointing this, addressed in latest PR.
ryankert01
reviewed
Jul 30, 2024
| Name: "test", | ||
| Namespace: "test", | ||
| Annotations: map[string]string{ | ||
| constants.NamespaceMaxApps: "5", |
There was a problem hiding this comment.
Could you add a negative test case as well? eg. -5.
There was a problem hiding this comment.
Good catch, addressed in latest PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…cations update.
What is this PR for?
We want to add ability to specify max apps via namespace annotations, this is the shim side change.
The si change has been merged apache/yunikorn-scheduler-interface#117
What type of PR is it?
Todos
What is the Jira issue?
[YUNIKORN-2] Gang scheduling interface parametersHow should this be tested?
Screenshots (if appropriate)
Questions: