Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2786] Improve convert2Namespace funtion's test coverage #887

Closed
wants to merge 2 commits into from

Conversation

SP12893678
Copy link
Contributor

What is this PR for?

Improve convert2Namespace funtion's test coverage

What type of PR is it?

  • -Test

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2786

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.07%. Comparing base (7f9901f) to head (64d903d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #887      +/-   ##
==========================================
+ Coverage   68.03%   68.07%   +0.03%     
==========================================
  Files          70       70              
  Lines        7598     7598              
==========================================
+ Hits         5169     5172       +3     
+ Misses       2214     2210       -4     
- Partials      215      216       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@brandboat brandboat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch, overall lgtm, just some nits.

@SP12893678
Copy link
Contributor Author

Thanks for the patch, overall lgtm, just some nits.

Thanks for your review!
I have fixed it

Copy link
Contributor

@chenyulin0719 chenyulin0719 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ryankert01 ryankert01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@brandboat brandboat closed this in c5f4074 Aug 8, 2024
@SP12893678 SP12893678 deleted the YUNIKORN-2786 branch September 1, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants