-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YUNIKORN-1957] Add e2e tests for user and group limits with wildcard #909
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the linter problems. You can check locally by running "make lint".
Hi @pbacsko , Fixed the Linter. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #909 +/- ##
=======================================
Coverage 68.18% 68.18%
=======================================
Files 70 70
Lines 7606 7606
=======================================
Hits 5186 5186
- Misses 2212 2213 +1
+ Partials 208 207 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
4c3249f
to
7f70e88
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 LGTM. Rebased on master to fix merge conflicts.
This PR introduces user and group limit test enhancements in the
user_group_limit_test.go
file. It adds new test cases to verify the behavior of the scheduler when user and group limits are set and updated. The tests cover scenarios where the user and group limits are exceeded, not defined, and changed. The PR also includes tests for wildcard users and group limits. These enhancements ensure that the scheduler correctly handles user and group limits in various scenarios.What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1957
How should this be tested?
Screenshots (if appropriate)
Questions: