[YUNIKORN-2857] Fix flaky gang scheduling e2e test #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #911 +/- ##
==========================================
- Coverage 68.20% 68.18% -0.03%
==========================================
Files 70 70
Lines 7606 7606
==========================================
- Hits 5188 5186 -2
- Misses 2211 2213 +2
Partials 207 207 ☔ View full report in Codecov by Sentry. |
craigcondit
force-pushed
the
YUNIKORN-2857
branch
from
c396b74 to
5c65eb8
Compare
craigcondit
force-pushed
the
YUNIKORN-2857
branch
from
5c65eb8 to
c6f7ffe
Compare
manirajv06
reviewed
Sep 9, 2024
| return false, err | ||
| } | ||
| lastOk, lastCount, lastReplaced, lastTimedOut = getPlaceholderData(appDaoInfo, tgName) | ||
| return lastOk && lastCount == count && lastReplaced == replaced && lastTimedOut == timedOut, nil |
There was a problem hiding this comment.
To avoid the API call again to assert allocationsCount at caller side, Can we either assert or return allocationsCount?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Don't return an error when polling for partition and queue after restart. Also, when polling for placeholder statuses, keep polling until values are as expected or timeout occurs.
What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2857
How should this be tested?
Screenshots (if appropriate)
Questions: