Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2368] Shim: Send updated resource requests to core #912

Closed
wants to merge 1 commit into from

Conversation

craigcondit
Copy link
Contributor

What is this PR for?

Now that the core supports resource updates for pods, send those in the shim if a pod is resized.

Since we're very close to 1.6.0 release, e2e tests will be done in a follow-up PR.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2368

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 79.54545% with 9 lines in your changes missing coverage. Please review.

Project coverage is 68.18%. Comparing base (b335500) to head (55314d9).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/cache/task.go 75.00% 7 Missing and 1 partial ⚠️
pkg/cache/context.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #912      +/-   ##
==========================================
- Coverage   68.20%   68.18%   -0.03%     
==========================================
  Files          70       70              
  Lines        7606     7621      +15     
==========================================
+ Hits         5188     5196       +8     
- Misses       2211     2217       +6     
- Partials      207      208       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pbacsko pbacsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@craigcondit craigcondit deleted the YUNIKORN-2368 branch September 9, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants