-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YUNIKORN-1977] E2E test for verifying user info with non kube-admin user #915
Closed
Closed
Changes from 12 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
62be8c1
[YUNIKORN-1977] Added E2E test for deploying pod and verifying user i…
rrajesh-cloudera f4e55e3
[YUNIKORN-1977] Added E2E test for deploying pod and verifying user i…
rrajesh-cloudera 9412297
[YUNIKORN-1977] Added E2E test for deploying pod and verifying user i…
rrajesh-cloudera 334cbb0
[YUNIKORN-1977] Added E2E test for deploying pod and verifying user i…
rrajesh-cloudera 4daafa0
[YUNIKORN-1977] restoring old kubeconfig file
rrajesh-cloudera f3b153a
[YUNIKORN-1977] accomdating review comments
rrajesh-cloudera 45f5266
[YUNIKORN-1977] accomdating review comments
rrajesh-cloudera e567e1c
[YUNIKORN-1977] accomdating review comments
rrajesh-cloudera b265689
Merge branch 'master' into YUNIKORN-1977
rrajesh-cloudera b2e717a
[YUNIKORN-1977] Accomdating PR Suggestions
rrajesh-cloudera 30954d5
Resolved merge conflicts
rrajesh-cloudera 735ceaf
[Yunikorn-1977] Accomdating PR Review Comments
rrajesh-cloudera a232066
[YUNIKORN-1977] accomdating PR Review comments
rrajesh-cloudera 2e25c0e
[YUNIKORN-1977] accomdating PR Review comments
rrajesh-cloudera File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This retry loop & sleep should definitely not be here. Normally, a getter function is only about retrieving something, whenever possible. If we have to wait for a value to show up, let's create a separate helper method for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the code with requested changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need to code the retry. We can take advantage of existing k8s functions.
To be consistent with existing code, let's use the following:
First, you call
kClient.WaitForSecret()
to indicate that you're waiting for a secret to appear over the API. Then callkClient.GetSecretValue()
. By having these 3 methods, all of them are usable indepdently of one another.