Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2971] Use FakeRecorder and MockedRecorder properly in the tests #937

Closed
wants to merge 1 commit into from

Conversation

pbacsko
Copy link
Contributor

@pbacsko pbacsko commented Nov 12, 2024

What is this PR for?

Remove FakeRecorder type check from the unit tests where it's present.
Also make sure that we always restore the default MockedRecorder in a deferred call wherever it's needed.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2971

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@pbacsko pbacsko self-assigned this Nov 12, 2024
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.03%. Comparing base (8fa300f) to head (1b81428).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #937   +/-   ##
=======================================
  Coverage   68.03%   68.03%           
=======================================
  Files          70       70           
  Lines        9194     9194           
=======================================
  Hits         6255     6255           
  Misses       2732     2732           
  Partials      207      207           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pbacsko pbacsko requested review from craigcondit, manirajv06, wilfred-s and chenyulin0719 and removed request for craigcondit November 12, 2024 19:00
Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants