Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2972] Remove Resource object from user group REST API #938

Closed
wants to merge 1 commit into from

Conversation

wilfred-s
Copy link
Contributor

What is this PR for?

e2e fixes for the removal of the Resource object from the REST API

What type of PR is it?

  • - Bug Fix

What is the Jira issue?

[YUNIKORN-2972] (https://issues.apache.org/jira/browse/YUNIKORN-2972)

How should this be tested?

This fixes a broken e2e tests

e2e fixes for the removal of the Resource object from the REST API
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.05%. Comparing base (735210c) to head (99aa90f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #938      +/-   ##
==========================================
+ Coverage   68.00%   68.05%   +0.05%     
==========================================
  Files          70       70              
  Lines        9194     9194              
==========================================
+ Hits         6252     6257       +5     
+ Misses       2734     2730       -4     
+ Partials      208      207       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pbacsko pbacsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM.

@wilfred-s wilfred-s deleted the YUNIKORN-2972 branch November 26, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants