Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2992] Emit warning message in plugin mode #943

Closed
wants to merge 2 commits into from
Closed

[YUNIKORN-2992] Emit warning message in plugin mode #943

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4a3270
[YUNIKORN-2992] Emit warning message in plugin mode
pbacsko Dec 6, 2024
a690773
spelling
pbacsko Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/plugin/scheduler_plugin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,7 @@
// NewSchedulerPlugin initializes a new plugin and returns it
func NewSchedulerPlugin(_ context.Context, _ runtime.Object, handle framework.Handle) (framework.Plugin, error) {
log.Log(log.ShimSchedulerPlugin).Info(conf.GetBuildInfoString())
log.Log(log.ShimSchedulerPlugin).Warn("The plugin mode has been deprecated and will be removed in a future release. Consider migrating to YuniKorn standalone mode.")

Check warning on line 272 in pkg/plugin/scheduler_plugin.go

View check run for this annotation

Codecov / codecov/patch

pkg/plugin/scheduler_plugin.go#L272 

Added line #L272 was not covered by tests

configMaps, err := client.LoadBootstrapConfigMaps()
if err != nil {
Expand Down
Loading