[YUNIKORN-2626] Add flag to helm chart to disable web container #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chia7712
reviewed
Jun 8, 2024
helm-charts/yunikorn/README.md
Outdated
| @@ -106,6 +106,7 @@ The following table lists the configurable parameters of the YuniKorn chart and | |||
| | `web.resources.limits.memory` | Web app memory resource limit | `500Mi` | | |||
| | `embedAdmissionController` | Flag for enabling/disabling the admission controller | `true` | | |||
| | `enableSchedulerPlugin` | Flag for enabling/disabling scheduler plugin mode | `false` | | |||
| | `enableWebService` | Flag for enabling/disabling web service | `true` | | |||
There was a problem hiding this comment.
please reformat this table
| @@ -30,10 +30,12 @@ spec: | |||
| targetPort: http1 | |||
| protocol: TCP | |||
| name: yunikorn-core | |||
| {{- if .Values.enableWebService }} | |||
There was a problem hiding this comment.
Could you please apply it to ingress also? If there is no web port, we don't need to configure ingress, right?
There was a problem hiding this comment.
Okay! I have applied the changes to the ingress.
|
@blueBlue0102 could you please test it locally and then attach the screenshot? |
|
@chia7712 without web: |
|
I've also validated the changes locally. |
chia7712
approved these changes
Jun 11, 2024
|
@chia7712 I've already created a PR for the site update here: apache/yunikorn-site#436. Please let me know if there are any other changes needed. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Add flag to helm chart to disable web container.
What type of PR is it?
What is the Jira issue?
How should this be tested?