Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZipOracle refactor #2763

Merged
merged 5 commits into from
Nov 8, 2023
Merged

ZipOracle refactor #2763

merged 5 commits into from
Nov 8, 2023

Conversation

Kukovec
Copy link
Collaborator

@Kukovec Kukovec commented Oct 20, 2023

  • Tests added for any new code
  • Ran make fmt-fix (or had formatting run automatically on all files edited)
  • Documentation added for any new functionality
  • Entries added to ./unreleased/ for any new functionality

Following the pattern laid out in #2709 for IntOracle, this PR introduces the same alterations to ZipOracle.

@Kukovec Kukovec requested review from thpani and konnov October 20, 2023 14:30
@Kukovec Kukovec requested a review from rodrigo7491 as a code owner October 20, 2023 14:30
Copy link
Collaborator

@konnov konnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good to me. Modulo the issues with the test failing in CI

@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2023

Codecov Report

Merging #2763 (10644f8) into main (cc0c47a) will increase coverage by 0.00%.
The diff coverage is 57.14%.

@@           Coverage Diff           @@
##             main    #2763   +/-   ##
=======================================
  Coverage   78.83%   78.83%           
=======================================
  Files         465      466    +1     
  Lines       15896    15903    +7     
  Branches     2583     2604   +21     
=======================================
+ Hits        12531    12537    +6     
- Misses       3365     3366    +1     
Files Coverage Δ
.../bmcmt/stratifiedRules/aux/oracles/ZipOracle.scala 57.14% <57.14%> (ø)

... and 2 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@Kukovec Kukovec merged commit d46cc5e into main Nov 8, 2023
10 checks passed
@Kukovec Kukovec deleted the jk/oracles4 branch November 8, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants