ApaxImport node fix #423
Open
ApaxImport node fix #423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
| @@ -219,6 +219,9 @@ def get_calculator(self, **kwargs) -> ase.calculators.calculator.Calculator: | |||
| ) | |||
| return calc | |||
|
|
|||
| def run(self) -> None: | |||
There was a problem hiding this comment.
is this required? it seems to have worked before. It might be desirable to turn this into a dataclass
There was a problem hiding this comment.
That would work if we don't use the state of the zntrack.Node from which we inherit. I think zntrack.Node implemented the run method in the past but now it gives an 'run method not implemented' error. I think this is an okish fix for now and can be reversed at the upcoming coding day.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added missing run function