Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add enum check of flags of create cmd #534

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

yipeng1030
Copy link
Contributor

@yipeng1030 yipeng1030 commented Jan 6, 2025

fix #533

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Jan 6, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 34.78261% with 15 lines in your changes missing coverage. Please review.

Project coverage is 41.22%. Comparing base (131c0cf) to head (57a0910).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/cmd/cluster/create_subcmds.go 34.78% 10 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #534      +/-   ##
==========================================
+ Coverage   41.20%   41.22%   +0.01%     
==========================================
  Files         187      187              
  Lines       25229    25252      +23     
==========================================
+ Hits        10396    10409      +13     
- Misses      13663    13669       +6     
- Partials     1170     1174       +4     
Flag Coverage Δ
unittests 41.22% <34.78%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yipeng1030 yipeng1030 marked this pull request as ready for review January 6, 2025 09:29
@yipeng1030 yipeng1030 merged commit 77d59e5 into main Jan 8, 2025
12 checks passed
@yipeng1030 yipeng1030 deleted the bugfix/add_enum_check_of_create_cmd branch January 8, 2025 03:27
@github-actions github-actions bot added this to the Release 1.0 milestone Jan 8, 2025
@yipeng1030
Copy link
Contributor Author

/cherry-pick release-1.0

apecloud-bot pushed a commit that referenced this pull request Jan 8, 2025
@apecloud-bot
Copy link
Collaborator

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kbcli/actions/runs/12663534278

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] A cluster could be created even when pod-anti-affinity was set as None
4 participants