Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve cluster create comment #570

Merged
merged 3 commits into from
Feb 21, 2025
Merged

Conversation

yipeng1030
Copy link
Contributor

fix #561

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines. label Feb 17, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 41.42%. Comparing base (1c84c8d) to head (511c884).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pkg/cmd/cluster/create.go 14.28% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #570      +/-   ##
==========================================
- Coverage   41.43%   41.42%   -0.01%     
==========================================
  Files         187      187              
  Lines       25053    25057       +4     
==========================================
  Hits        10380    10380              
- Misses      13495    13499       +4     
  Partials     1178     1178              
Flag Coverage Δ
unittests 41.42% <14.28%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wangyelei wangyelei merged commit 7b5de6b into main Feb 21, 2025
12 checks passed
@wangyelei wangyelei deleted the bugfix/improve_cluster_create branch February 21, 2025 02:47
@wangyelei
Copy link
Contributor

/cherry-pick release-1.0

@github-actions github-actions bot added this to the Release 1.0 milestone Feb 21, 2025
@apecloud-bot
Copy link
Collaborator

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kbcli/actions/runs/13448989358

apecloud-bot pushed a commit that referenced this pull request Feb 21, 2025
Co-authored-by: yipeng1030 <[email protected]>
(cherry picked from commit 7b5de6b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] kbcli cluster create. print help info instead of no implement
5 participants