Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor parameters partI: add parameters group and api #8582

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

sophon-zt
Copy link
Contributor

No description provided.

@sophon-zt sophon-zt requested review from a team, leon-inf and Y-Rookie as code owners December 4, 2024 10:29
@github-actions github-actions bot added the size/XXL Denotes a PR that changes 1000+ lines. label Dec 4, 2024
@sophon-zt sophon-zt force-pushed the support/improvement-parameters-api-part1 branch from 03253e6 to 6297fee Compare December 4, 2024 10:32
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 54.41478% with 222 lines in your changes missing coverage. Please review.

Project coverage is 60.48%. Comparing base (3d89b29) to head (2fca37e).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controllerutil/parameter_schema.go 0.00% 95 Missing ⚠️
pkg/controllerutil/config_util.go 0.00% 37 Missing ⚠️
...lers/parameters/parametersdefinition_controller.go 64.51% 24 Missing and 9 partials ⚠️
pkg/controller/configuration/parameter_utils.go 82.10% 12 Missing and 5 partials ⚠️
controllers/parameters/config_reconcile_wrapper.go 27.77% 13 Missing ⚠️
pkg/controller/configuration/resource_wrapper.go 0.00% 12 Missing ⚠️
...rameters/parameterdrivenconfigrender_controller.go 89.02% 6 Missing and 3 partials ⚠️
pkg/controller/builder/builder_component.go 0.00% 3 Missing ⚠️
.../controller/builder/builder_component_parameter.go 85.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8582      +/-   ##
==========================================
- Coverage   60.57%   60.48%   -0.10%     
==========================================
  Files         378      384       +6     
  Lines       45696    46095     +399     
==========================================
+ Hits        27682    27879     +197     
- Misses      15418    15608     +190     
- Partials     2596     2608      +12     
Flag Coverage Δ
unittests 60.48% <54.41%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sophon-zt sophon-zt force-pushed the support/improvement-parameters-api-part1 branch from de53cf4 to 2fca37e Compare December 11, 2024 06:59
@sophon-zt sophon-zt force-pushed the support/improvement-parameters-api-part1 branch from 9bca90e to 4f6ba57 Compare December 25, 2024 04:14
@shanshanying shanshanying added this to the Release 1.0.0 milestone Jan 3, 2025
@github-actions github-actions bot modified the milestones: Release 1.0.0, Release 0.9.3 Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants