Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor parameters partV: decouple apps dependence on parameters and tidy up #8620

Draft
wants to merge 7 commits into
base: support/improvement-parameters-api-part2
Choose a base branch
from

Conversation

sophon-zt
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 57.43707% with 186 lines in your changes missing coverage. Please review.

Project coverage is 59.91%. Comparing base (4e0d6a2) to head (7a7d3fe).

Files with missing lines Patch % Lines
.../parameters/componentdrivenparameter_controller.go 62.67% 39 Missing and 14 partials ⚠️
controllers/parameters/reconcile_task.go 60.00% 33 Missing and 15 partials ⚠️
...trollers/apps/transformer_component_reconfigure.go 62.33% 22 Missing and 7 partials ⚠️
pkg/controller/configuration/config_utils.go 0.00% 22 Missing ⚠️
pkg/controller/configuration/template_validate.go 32.14% 19 Missing ⚠️
pkg/controller/configuration/template_render.go 69.23% 8 Missing and 4 partials ⚠️
pkg/controller/configuration/resource_wrapper.go 0.00% 2 Missing ⚠️
controllers/apps/component_controller.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@                             Coverage Diff                              @@
##           support/improvement-parameters-api-part2    #8620      +/-   ##
============================================================================
- Coverage                                     59.97%   59.91%   -0.07%     
============================================================================
  Files                                           383      381       -2     
  Lines                                         45479    45234     -245     
============================================================================
- Hits                                          27278    27101     -177     
+ Misses                                        15612    15575      -37     
+ Partials                                       2589     2558      -31     
Flag Coverage Δ
unittests 59.91% <57.43%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sophon-zt sophon-zt force-pushed the support/improvement-parameters-api-part2 branch from 75ef901 to 0d108f2 Compare December 11, 2024 07:01
@sophon-zt sophon-zt force-pushed the support/improvement-parameters-api-part3 branch from 49d7667 to 6f0dff5 Compare December 11, 2024 07:06
@sophon-zt sophon-zt marked this pull request as ready for review December 11, 2024 08:53
@sophon-zt sophon-zt requested review from leon-inf, Y-Rookie and a team as code owners December 11, 2024 08:53
@sophon-zt sophon-zt marked this pull request as draft December 12, 2024 02:24
@sophon-zt sophon-zt force-pushed the support/improvement-parameters-api-part2 branch from 0d108f2 to 31b29ca Compare December 12, 2024 02:25
@sophon-zt sophon-zt force-pushed the support/improvement-parameters-api-part3 branch 4 times, most recently from 7846fb1 to 7a7d3fe Compare December 13, 2024 09:40
@sophon-zt sophon-zt force-pushed the support/improvement-parameters-api-part2 branch from 4e0d6a2 to 0f9f06e Compare December 25, 2024 05:06
@sophon-zt sophon-zt force-pushed the support/improvement-parameters-api-part3 branch from 7a7d3fe to 001e812 Compare December 25, 2024 05:40
@shanshanying shanshanying added this to the Release 1.0.0 milestone Jan 3, 2025
@github-actions github-actions bot modified the milestones: Release 1.0.0, Release 0.9.3 Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants