-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refactor parameters partV: decouple apps dependence on parameters and tidy up #8620
Draft
sophon-zt
wants to merge
7
commits into
support/improvement-parameters-api-part2
Choose a base branch
from
support/improvement-parameters-api-part3
base: support/improvement-parameters-api-part2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
chore: refactor parameters partV: decouple apps dependence on parameters and tidy up #8620
sophon-zt
wants to merge
7
commits into
support/improvement-parameters-api-part2
from
support/improvement-parameters-api-part3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## support/improvement-parameters-api-part2 #8620 +/- ##
============================================================================
- Coverage 59.97% 59.91% -0.07%
============================================================================
Files 383 381 -2
Lines 45479 45234 -245
============================================================================
- Hits 27278 27101 -177
+ Misses 15612 15575 -37
+ Partials 2589 2558 -31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sophon-zt
force-pushed
the
support/improvement-parameters-api-part2
branch
from
December 11, 2024 07:01
75ef901
to
0d108f2
Compare
sophon-zt
force-pushed
the
support/improvement-parameters-api-part3
branch
from
December 11, 2024 07:06
49d7667
to
6f0dff5
Compare
sophon-zt
requested review from
leon-inf,
Y-Rookie and
a team
as code owners
December 11, 2024 08:53
sophon-zt
force-pushed
the
support/improvement-parameters-api-part2
branch
from
December 12, 2024 02:25
0d108f2
to
31b29ca
Compare
sophon-zt
force-pushed
the
support/improvement-parameters-api-part3
branch
4 times, most recently
from
December 13, 2024 09:40
7846fb1
to
7a7d3fe
Compare
sophon-zt
force-pushed
the
support/improvement-parameters-api-part2
branch
from
December 25, 2024 05:06
4e0d6a2
to
0f9f06e
Compare
sophon-zt
force-pushed
the
support/improvement-parameters-api-part3
branch
from
December 25, 2024 05:40
7a7d3fe
to
001e812
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.