Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed cancel button issue: changed "Cancel" to "Go Back" #491

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fixed cancel button issue: changed "Cancel" to "Go Back" #491

wants to merge 2 commits into from
+4 −3

Conversation

gopalM-3
Copy link

fixes issue #362 by changing the 't' function's input text from "Cancel" to "Go Back" in both DocTranslationForm.tsx and WebpageTranslationForm.tsx

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8283268235

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.644%
Totals Coverage Status
Change from base Build 8267419293: 0.0%
Covered Lines: 1381
Relevant Lines: 1396
💛 - Coveralls

sushain97
sushain97 requested changes Mar 19, 2024
View reviewed changes
Copy link
Member

@sushain97 sushain97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Go Back string doesn't exist in any of the translation JSON files. In particular, it must exist in eng.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sushain97 sushain97 sushain97 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gopalM-3 @coveralls @sushain97