Refactor :: Notification N+1 이슈 및 캐싱 적용 #346 #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
기존 쿼리를 두 단계로 나눠서 N+1 문제를 변경함 기존 쿼리에선 N+1 이 발생해 조회를 여러번 했는데 이를 2번 쿼리를 나누어 날려 빈도수를 줄이고 속도 개선을 함
기존 schedules 랑 달리 생성, 수정, 삭제 시 cache 값 변동이 필요하여 기존과 다른 로직 변경
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
#346
📝 작업 내용
2.1. 기존 조회 캐싱방식과 다르게 C, U, D 에 대한 반응도 해야해서 로직이 조금 변동되었습니다.
📎 ETC
학사일정 K6 테스트 결과 응답속도가 97.93% 개선 되었습니다.
N+1, 캐싱 적용 됬으니 Notification도 유의미한 결과가 도출될꺼라 예상합니다.