Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle empty inputs and show better errors for inputs with varying deepness #7

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

percevalw
Copy link
Member

Description

  • Handle empty inputs (e.g. as_folded_tensor([[[], []], [[]]])) by returning an empty tensor
  • Correctly bubble errors when converting inputs with varying deepness (e.g. as_folded_tensor([1, [2, 3]]))

Checklist

  • If this PR is a bug fix, the bug is documented in the test suite.
  • Changes were documented in the changelog (pending section).
  • If necessary, changes were made to the documentation.

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d1f24cd) 100.00% compared to head (6f16b1a) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main        #7   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          138       145    +7     
=========================================
+ Hits           138       145    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@percevalw percevalw merged commit d154ec6 into main Feb 14, 2024
13 checks passed
@percevalw percevalw deleted the empty-and-imbalanced-inputs branch February 14, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant