Fractal: explode can't be null in php 8 - set default include input t…

…o empty string (#25) * explode can't be null in php 8 set default include input to empty string * additional test to validate working fractal without includes Co-authored-by: Christoph Kluge <[email protected]>
api-ecosystem-for-laravel · Aug 31, 2022 · e2980b6 · e2980b6
1 parent 25ebd2d
commit e2980b6
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/Transformer/Adapter/Fractal.php b/src/Transformer/Adapter/Fractal.php
@@ -161,7 +161,7 @@ protected function createResource($response, $transformer, array $parameters)
      */
     public function parseFractalIncludes(Request $request)
     {
-        $includes = $request->input($this->includeKey);
+        $includes = $request->input($this->includeKey, '');
 
         if (! is_array($includes)) {
             $includes = array_map('trim', array_filter(explode($this->includeSeparator, $includes)));

diff --git a/tests/Transformer/Adapter/FractalTest.php b/tests/Transformer/Adapter/FractalTest.php
@@ -33,4 +33,13 @@ public function testParseFractalIncludesWithSpaces()
 
         $this->assertEquals(['foo', 'bar'], $requestedIncludes);
     }
+
+    public function testParseFractalWithoutAnyGivenIncludes()
+    {
+        $request = Request::create('/', 'GET');
+        $this->fractal->parseFractalIncludes($request);
+        $requestedIncludes = $this->fractal->getFractal()->getRequestedIncludes();
+
+        $this->assertEquals([], $requestedIncludes);
+    }
 }