Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make the development process easier with Storybook #541

Merged
Merged
Changes from 1 commit
Commits
Show all changes
68 commits
Select commit Hold shift + click to select a range
6d267e8
chore: add auth storie and test
adguernier Mar 25, 2024
c288451
fix: Auth test did not use correct endpoint
adguernier Mar 26, 2024
0360d52
fix: TS warning
adguernier Mar 26, 2024
93f6641
fix: use env for storybook tests
adguernier Mar 26, 2024
bdeaee8
CI: run interaction test in CI
adguernier Mar 27, 2024
76e4c20
fix: NODE_ENV does not exist and expect is declared but its value is …
adguernier Mar 27, 2024
bb524d8
fix: expect is declared but its value is never read in check build
adguernier Mar 27, 2024
3346b0b
fix: unexpected any in checking code standards
adguernier Mar 27, 2024
c37676c
fix: remove useless test
adguernier Mar 27, 2024
95cb317
fix: check PWA reachability fails
adguernier Mar 28, 2024
3f2b8dd
fix: try to fix check PWA reachability fails
adguernier Mar 28, 2024
e15b7d4
fix: uncomment reachability steps
adguernier Mar 28, 2024
81fd9aa
fix: try to fix reachability steps
adguernier Mar 28, 2024
500ce1f
fix: try to fix reachability steps by healthchecking pwa
adguernier Mar 28, 2024
9087b62
fix: try to fix Timeout error in interactions tests by setting maxWor…
adguernier Mar 28, 2024
037241a
fix: try to fix Timeout error in interactions tests by setting maxWor…
adguernier Mar 28, 2024
e48682a
fix: try to fix Timeout error in interactions tests by setting maxWor…
adguernier Mar 28, 2024
4b7f486
fix: try to fix Timeout error in interactions tests by adding timeout…
adguernier Mar 28, 2024
140834e
chore: remove useless type
adguernier Mar 28, 2024
b71151e
chore: add @types/node to fix Failed to parse the TypeScript config f…
adguernier Mar 28, 2024
083c018
chore: try to fix test by setting a hight testTimeout
adguernier Mar 28, 2024
474eacc
chore: try to fix test by waiting for page ready
adguernier Mar 28, 2024
5c1ec91
chore: try to fix test by waiting for page ready
adguernier Mar 28, 2024
a04727d
chore: try to fix test
adguernier Mar 28, 2024
9e2b476
chore: upgrade storybook to version 8
adguernier Mar 28, 2024
16f7c45
chore: try to get playwright artifact
adguernier Mar 29, 2024
1e267f4
chore: try to fix storybook tests
adguernier Apr 3, 2024
dade8fb
chore: retry to build and bake
adguernier Apr 3, 2024
f7fda1a
chore: compose up without build
adguernier Apr 3, 2024
45acfa7
chore: add yarn install to CMD
adguernier Apr 3, 2024
e487570
chore: update yarn.lock
adguernier Apr 4, 2024
d4eacbb
switch back to nodeLinker node-modules
slax57 Apr 4, 2024
9573e03
update gitignore to ignore storybook build result
slax57 Apr 5, 2024
48710b7
re-enable playwright install
slax57 Apr 5, 2024
77804a4
disable reverse_proxy
slax57 Apr 5, 2024
39025f5
re-enable reverse proxy and fix its config
slax57 Apr 5, 2024
bfca4e5
re-enable reachability checks
slax57 Apr 5, 2024
5befd5b
re-remove reverse proxy
slax57 Apr 5, 2024
6405534
attempt to fix yarn playwright install
slax57 Apr 5, 2024
acd11d2
check health more frquently and output logs in case of failure
slax57 Apr 5, 2024
23e0760
Merge branch 'main' into chore/add-jwt-backend-and-stories
slax57 Apr 5, 2024
7528365
fix merge mistake
slax57 Apr 5, 2024
e781ebe
try to fix yarn settings
slax57 Apr 5, 2024
92e168e
improve debug logs
slax57 Apr 5, 2024
d9bfd83
remove broken checks and fix volumes config
slax57 Apr 5, 2024
4f03e4b
fix node_modules volume should only be declared for ci
slax57 Apr 5, 2024
8e347fc
fix runtime error in hydra dataProvider
slax57 Apr 5, 2024
9fe98e2
update CONTRIBUTING
adguernier Apr 8, 2024
9fc1471
install Twig to make API doc working
adguernier Apr 8, 2024
c2d4a16
fix: use params instead of defaultParams in extraInformation
adguernier Apr 8, 2024
5d70a2a
chore: clean yarn cache after modules installation
adguernier Apr 8, 2024
5ae05bb
chore: explain how to develop through Storybook
adguernier Apr 8, 2024
e1370ff
chore: clean yarn cache in CI
adguernier Apr 8, 2024
d7de715
chore: try to fix docker file linter in CI
adguernier Apr 8, 2024
0c7f0d0
chore: try to fix docker file linter in CI by ignoring DL3060 rule
adguernier Apr 8, 2024
e3eeedc
chore: try to fix docker file linter in CI by ignoring DL3060 rule
adguernier Apr 8, 2024
02cde2e
chore: try to fix docker linter in CI
adguernier Apr 8, 2024
73e279d
chore: remove useless actions
adguernier Apr 8, 2024
8917e12
chore: add Storybook documentation
adguernier Apr 8, 2024
70e90a6
chore: re-add buildx and bake action
adguernier Apr 9, 2024
f91c2a6
chore: add compose.ci.yaml to bake-action
adguernier Apr 9, 2024
cc10da7
chore: fix typos from review
adguernier Apr 15, 2024
bcc81b3
Apply suggestions from code review
adguernier Apr 18, 2024
eb3d456
remove useless php packages
adguernier Apr 18, 2024
cf539af
fix: ignore cert errors
alanpoulain May 2, 2024
a376ec9
chore: update contributing to explain how to run tests
adguernier May 2, 2024
64e0a1b
chore: remove comment in cache.yaml
adguernier May 2, 2024
be380d5
chore: isntall playwright for all images
adguernier May 2, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
try to fix yarn settings
slax57 committed Apr 5, 2024
commit e781ebe7545d8b9c60d238ed88a1aa02a28dcecb
8 changes: 3 additions & 5 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -28,16 +28,14 @@

FROM base as ci

# EXPOSE 3001
# ENV PORT 3001
COPY --link package.json yarn.lock .yarnrc.yml ./
RUN set -eux; \
yarn

# copy sources
COPY --link . ./

RUN set -eux; \
yarn

RUN set -eux; \

Check failure on line 38 in Dockerfile

GitHub Actions / Docker Lint

DL3060 info: `yarn cache clean` missing after `yarn install` was run.
yarn playwright install --with-deps

CMD ["sh", "-c", "yarn storybook:build && yarn storybook:serve -p 3000"]