Skip to content

Do not fail if phpstan/phpdoc-parser is missing #7279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: 4.1
Choose a base branch
from

Conversation

VincentLanglet
Copy link
Contributor

@VincentLanglet VincentLanglet commented Jul 5, 2025

Q A
Branch? 4.1
Tickets Closes #7275
License MIT
Doc PR api-platform/docs#...

Not fully sure about this one @soyuka but

So since phpDocParser/lexer will be null when PhpDocParser is not installed, a null check might be enough.

@VincentLanglet VincentLanglet changed the title Require phpstan/phpdoc-parser Do not fail if phpstan/phpdoc-parser is missing Jul 5, 2025
@VincentLanglet
Copy link
Contributor Author

@PicassoHouessou could you try this branch ? Does it solve your issue ?

@PicassoHouessou
Copy link

Hello @VincentLanglet. It solves my issue.

Copy link
Contributor

@maxhelias maxhelias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It ok for me, as "phpstan/phpdoc-parser" is also a suggested package for metadata component : https://github.com/api-platform/core/blob/4.1/src/Metadata/composer.json#L52

@maxhelias
Copy link
Contributor

Also, in Laravel, can you unconfigure the service if the dependency is not present? This would be better for performance, even if there is a cache on MetadataFactory services

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants