Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebrand DAO Dashboard - Modals #457

Closed
peterjurco opened this issue Oct 15, 2024 · 7 comments · Fixed by #495
Closed

Rebrand DAO Dashboard - Modals #457

peterjurco opened this issue Oct 15, 2024 · 7 comments · Fixed by #495

Comments

@peterjurco
Copy link
Collaborator

peterjurco commented Oct 15, 2024

Update styles of modals on the staking page based on the new designs. This includes

  • Stake / Unstake / Deposit / Withdraw modals
  • Unsupported chain modal
@peterjurco peterjurco assigned peterjurco and unassigned peterjurco Nov 13, 2024
@Anboias Anboias self-assigned this Nov 14, 2024
@peterjurco peterjurco changed the title Rebrand DAO Dashboard - Modals Rebrand DAO Dashboard - Staking page modals Nov 15, 2024
@Anboias Anboias changed the title Rebrand DAO Dashboard - Staking page modals Rebrand DAO Dashboard - Modals Nov 18, 2024
@Anboias Anboias mentioned this issue Nov 20, 2024
@Anboias Anboias linked a pull request Nov 20, 2024 that will close this issue
@PrenaamD
Copy link
Collaborator

@Anboias
Feedback 1
According to the design, "Once staked, you will not be able to unstake your tokens for 7 days." is displayed after the deposit amount is approved, not before. In the implementation, it is always displayed in the deposit modal.
Screen Shot 2024-11-26 at 14 34 04 PM

Feedback 2

  1. On all the modals, the text should be "How many API3 tokens would you like to ..." instead of "How many tokens would you like to ..."
  2. On the Unstaking modal, instead of "Your balance" it should be "Staked tokens"
  3. On the Staking modal, instead of "Your balance" it should be "Wallet balance"
  4. On the withdraw modal, instead of "Your balance" it should be "Withdrawable tokens"
  5. Actually, there seems to be an inconsistency in the design, in the screenshot below, the deposit modal has "your balance" and "wallet balance"

Screen Shot 2024-11-26 at 14 52 25 PM

Screen Shot 2024-11-26 at 14 45 20 PM

@Anboias
Copy link
Collaborator

Anboias commented Nov 27, 2024

Thanks for the thorough review, @PrenaamD.

I must agree with @peterjurco's comment here. We only focused on the design part of things, leaving the logic as-is. Would you be so kind to check the above with the Design Team as well? We have a Design meeting later today, perhaps you could join us

@PrenaamD
Copy link
Collaborator

@Anboias I think it can be addressed in a separate issue after checking with the design team.

@Anboias
Copy link
Collaborator

Anboias commented Nov 28, 2024

I think it can be addressed in a separate issue after checking with the design team.

@PrenaamD, agree 🙏

Just for the record, I mentioned this issue in yesterday's design call. I was told that, with a few exceptions, Figma typing is outdated and Production version is the source of truth.

@T9991
Copy link

T9991 commented Dec 2, 2024

Feedback 1
According to the design, "Once staked, you will not be able to unstake your tokens for 7 days." is displayed after the deposit amount is approved, not before. In the implementation, it is always displayed in the deposit modal.

Will update the designs to reflect this.✅ I think we added it after to draw more attention of something appearing.

Feedback 2: 1. On all the modals, the text should be "How many API3 tokens would you like to ..." instead of "How many tokens would you like to ..."

I completely disagree with this. The token name should be stated.

  1. On the Unstaking modal, instead of "Your balance" it should be "Staked tokens"

Can't find this in the designs- I assume it was updated during/after a call?

  1. On the Staking modal, instead of "Your balance" it should be "Wallet balance"

Commented to update ✅

  1. On the withdraw modal, instead of "Your balance" it should be "Withdrawable tokens" & 5. Actually, there seems to be an inconsistency in the design, in the screenshot below, the deposit modal has "your balance" and "wallet balance"

Commented on the designs to update ✅ Wallet balance should be used for deposit modals. Your balance for staking modals.

@Anboias
Copy link
Collaborator

Anboias commented Dec 3, 2024

@T9991, have you added all your feedback to this ticket?

After everything is done on your side, we can pick the ticket up and apply the changes in the code. But it helps to have the full list somewhere so that we know what to change.

@T9991
Copy link

T9991 commented Dec 3, 2024

@Anboias Yes, that's everything

@Anboias Anboias closed this as completed Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants