-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebrand modals #495
Rebrand modals #495
Conversation
a9faa18
to
d796283
Compare
ed84d29
to
25214fc
Compare
@peterjurco, pushed a new commit called
e.g. Deposit modal
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid work here 👏 Thanks also for the detailed PR description
655a6dd
to
7a72e11
Compare
Closes #457
What does this do?
Button component:
Input component:
Modal component:
Modals:
Why change the Button?
The div around the Button was unnecessary and it was affecting the New Proposal modal's Help tooltip display.
The footer Button focus was plain wrong and I took this opportunity to fix it.
Button footer focus issue
Before
Screen.Recording.2024-11-21.at.11.42.21.mov
Now
Screen.Recording.2024-11-21.at.11.40.26.mov
Deposit modal (Withdraw / Stake / Unstake are similar)
Confirm Unstake modal
Unsupported Network modal