Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebrand modals #495

Merged
merged 12 commits into from
Nov 28, 2024
Merged

Rebrand modals #495

merged 12 commits into from
Nov 28, 2024

Conversation

Anboias
Copy link
Collaborator

@Anboias Anboias commented Nov 20, 2024

Closes #457

What does this do?

Button component:

  • remove unnecessary Button div wrapper
  • fix footer focus border on key navigation (see video below)
  • add new variants (tertiary & text-blue)

Input component:

  • update Input component to new Branding

Modal component:

  • update main Modal component to new Branding

Modals:

  • update Deposit / Withdraw / Stake / Unstake modals
  • update Confirm Unstake modal
  • update Unsupported chains modal

Why change the Button?

The div around the Button was unnecessary and it was affecting the New Proposal modal's Help tooltip display.
The footer Button focus was plain wrong and I took this opportunity to fix it.

Button footer focus issue

Before

Screen.Recording.2024-11-21.at.11.42.21.mov

Now

Screen.Recording.2024-11-21.at.11.40.26.mov

Deposit modal (Withdraw / Stake / Unstake are similar)

Mobile Desktop
image image

Confirm Unstake modal

Mobile Desktop
image image

Unsupported Network modal

Mobile Desktop
image image

@Anboias Anboias self-assigned this Nov 20, 2024
@Anboias Anboias linked an issue Nov 20, 2024 that may be closed by this pull request
Base automatically changed from 487/rebrand-tooltips to rebrand November 20, 2024 14:11
@Anboias Anboias force-pushed the 457/rebrand-modals branch 3 times, most recently from ed84d29 to 25214fc Compare November 21, 2024 11:42
@Anboias Anboias marked this pull request as ready for review November 21, 2024 11:43
@Anboias
Copy link
Collaborator Author

Anboias commented Nov 21, 2024

@peterjurco, pushed a new commit called Show primary buttons first on mobile. It corrects the display order of two buttons from a modal, of which one is primary. Discussed here.

T: As far as stacking, the buttons should be reversed. the main CTA is always on the top

e.g. Deposit modal

Before Now
image image

Copy link
Collaborator

@peterjurco peterjurco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid work here 👏 Thanks also for the detailed PR description

src/components/modal/modal.tsx Show resolved Hide resolved
@Anboias Anboias merged commit 7836448 into rebrand Nov 28, 2024
3 of 4 checks passed
@Anboias Anboias deleted the 457/rebrand-modals branch November 28, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rebrand DAO Dashboard - Modals
3 participants