Rebrand staking page #474
Merged
Rebrand staking page #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anboias
commented
Nov 12, 2024
peterjurco
requested changes
Nov 13, 2024
src/pages/dashboard/pending-unstake-panel/pending-unstake-panel.tsx
Outdated
Show resolved
Hide resolved
mcoetzee
approved these changes
Nov 14, 2024
peterjurco
approved these changes
Nov 15, 2024
Anboias
force-pushed
the
456/rebrand-staking-page
branch
from
2d179ab to
dd9d98e
Compare
mcoetzee
reviewed
Nov 15, 2024
cypress/e2e/delegation.cy.ts
Outdated
| @@ -5,7 +5,7 @@ describe('delegation', () => { | |||
| cy.resetBlockchain().login(); | |||
|
|
|||
| // Approve, deposit and stake | |||
| cy.findByText('+ Deposit').click(); | |||
| cy.dataCy('staking-cards').findByRole('button', { name: 'Deposit' }).click(); | |||
There was a problem hiding this comment.
Lets rather use the built in data-testid="..." and cy.findByTestId(...) for all of these cy.dataCy() usages that you've added.
There was a problem hiding this comment.
Done. Replaced both dataCy and findByRole with findByTestId.
If you meant to replace only dataCy with findByTestId, I'll quickly adjust.
peterjurco
added a commit
that referenced
this pull request
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #456
Designs
What does this do?
What is this not doing?
Screenshots
Pending unstaking
Main view