Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout fixes #494

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Layout fixes #494

merged 3 commits into from
Nov 20, 2024

Conversation

peterjurco
Copy link
Collaborator

@peterjurco peterjurco commented Nov 19, 2024

Small fixes on the rebranded layout.

  • Fix: With not enough content on the page, the footer wasn't on the bottom of the page
  • Fix: History icon incorrect React component props
  • Fix: Add hover & active states to the menu items (figma)

@peterjurco peterjurco self-assigned this Nov 19, 2024
}

.content {
display: flex;
flex-grow: 1;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@peterjurco peterjurco requested a review from mcoetzee November 20, 2024 07:58
@peterjurco
Copy link
Collaborator Author

@mcoetzee, assigning you for visibility but since this is a small one, I'm going to merge

@peterjurco peterjurco merged commit 0ed47aa into rebrand Nov 20, 2024
3 of 4 checks passed
@peterjurco peterjurco deleted the fix/layout branch November 20, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants