Rebrand New Proposal modal #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Anboias
force-pushed
the
464/new-proposal-modal
branch
2 times, most recently
from
4f50563 to
7db9903
Compare
Anboias
force-pushed
the
457/rebrand-modals
branch
from
655a6dd to
7a72e11
Compare
Anboias
force-pushed
the
464/new-proposal-modal
branch
from
7db9903 to
397fc81
Compare
peterjurco
approved these changes
Nov 27, 2024
|
Added a new commit with the following two changes:
I expect to make another commit soon, after the 
|
Anboias
force-pushed
the
464/new-proposal-modal
branch
from
dbee821 to
ef8745c
Compare
mcoetzee
reviewed
Nov 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #464
What does this do?
Updates New Proposal modal to new branding
How did I action this?
I split the existing
Inputcomponent in two (AutosizeInputandTextareaInput), because the input from other modals and input from this one diverged too much. Felt like there was no point in overcrowding all the logic into a single fileDesigns only show us two screens for the Modal: SM and LG. Had to fill the gaps myself, so I did some small adjustments in terms of spacings and sizings for MD (between 768 and 1200) to make things fit better
Screenshots
SM
MD
LG