Skip to content

Add Enclabs to OEV searching candidates #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

matejfalat
Copy link
Contributor

No description provided.

Copy link

Visit the preview URL for this PR (updated for commit cd9466b):

https://oev-docs--pr202-add-enclabs-pkhuq2rd.web.app

(expires Tue, 01 Jul 2025 08:55:30 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 6915b094b5ba83fde754632ba50c1ee9406d433f

@@ -25,6 +25,7 @@ The following table includes dApps which integrated OEV proxies and are good can
| dApp | Chain | dApp alias |
| -------------------------------------------------------------------------------------------------------------------------------------------------- | -------------- | ----------------------------- |
| [dTRINITY](https://dtrinity.org/) | Fraxtal, Sonic | `dtrinity` |
| [Enclabs](https://www.enclabs.finance/) | Sonic | `enclabs` |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did they switch to their given proxies? We should only merge this once that is done.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No not yet. I thought it's not much of a searchers' concern, but the PR can wait 👍

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem by listing them on this page you're essentially telling the searchers they can derive the dApp ID with the above data and start searching. That is obviously wrong, because they are still using proxies with dApp ID 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants