-
Notifications
You must be signed in to change notification settings - Fork 4
Adds data-feed-proxy-combinators docs #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Visit the preview URL for this PR (updated for commit 7cf84bc): https://oev-docs--pr210-data-feed-proxy-comb-40m36top.web.app (expires Wed, 30 Jul 2025 17:47:39 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6915b094b5ba83fde754632ba50c1ee9406d433f |
I'd just include it in https://oev-docs--pr210-data-feed-proxy-comb-40m36top.web.app/dapps/integration/api3-contracts.html I don't think we need the sidebar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@acenolaza not sure if you saw
I'd just include it in https://oev-docs--pr210-data-feed-proxy-comb-40m36top.web.app/dapps/integration/api3-contracts.html I don't think we need the sidebar.
Sorry, missed that message. I'll apply that change |
Removed the sidebar link, added a short description and link to api3-contracts.md but I'm wondering if here wouldn't be a better place to like the data-feed-proxy-combinators repo 🤔 |
Yeah, maybe it's better to mention it after the mixed oracle design section. |
…ntract-integration.md
72be0a1
to
ef4d160
Compare
Ended up placing the text before the mixed oracle design section and right after the reading a data feed section |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final changes from me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've changed my mind on how I like the looks of it, but approving. Once you fix this request review from Burak as he's responsible for the dApp's part of docs.
Co-authored-by: Burak Benligiray <[email protected]>
Closes api3dao/data-feed-proxy-combinators#26