Skip to content

Adds data-feed-proxy-combinators docs #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 23, 2025
Merged

Conversation

acenolaza
Copy link
Contributor

@acenolaza acenolaza requested a review from Siegrift July 17, 2025 23:24
Copy link

github-actions bot commented Jul 17, 2025

Visit the preview URL for this PR (updated for commit 7cf84bc):

https://oev-docs--pr210-data-feed-proxy-comb-40m36top.web.app

(expires Wed, 30 Jul 2025 17:47:39 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 6915b094b5ba83fde754632ba50c1ee9406d433f

@Siegrift
Copy link
Collaborator

I'd just include it in https://oev-docs--pr210-data-feed-proxy-comb-40m36top.web.app/dapps/integration/api3-contracts.html I don't think we need the sidebar.

@acenolaza acenolaza requested a review from Siegrift July 18, 2025 13:38
Copy link
Collaborator

@Siegrift Siegrift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@acenolaza not sure if you saw

I'd just include it in https://oev-docs--pr210-data-feed-proxy-comb-40m36top.web.app/dapps/integration/api3-contracts.html I don't think we need the sidebar.

@acenolaza
Copy link
Contributor Author

@acenolaza not sure if you saw

I'd just include it in https://oev-docs--pr210-data-feed-proxy-comb-40m36top.web.app/dapps/integration/api3-contracts.html I don't think we need the sidebar.

Sorry, missed that message. I'll apply that change

@acenolaza
Copy link
Contributor Author

I'd just include it in https://oev-docs--pr210-data-feed-proxy-comb-40m36top.web.app/dapps/integration/api3-contracts.html I don't think we need the sidebar.

Removed the sidebar link, added a short description and link to api3-contracts.md but I'm wondering if here wouldn't be a better place to like the data-feed-proxy-combinators repo 🤔

@acenolaza acenolaza requested a review from Siegrift July 21, 2025 15:11
@Siegrift
Copy link
Collaborator

I'm wondering if here wouldn't be a better place to like the data-feed-proxy-combinators repo 🤔

Yeah, maybe it's better to mention it after the mixed oracle design section.

@acenolaza acenolaza force-pushed the data-feed-proxy-combinators branch from 72be0a1 to ef4d160 Compare July 21, 2025 20:17
@acenolaza
Copy link
Contributor Author

Yeah, maybe it's better to mention it after the mixed oracle design section.

Ended up placing the text before the mixed oracle design section and right after the reading a data feed section

Copy link
Collaborator

@Siegrift Siegrift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final changes from me.

@acenolaza acenolaza requested a review from Siegrift July 22, 2025 12:16
Copy link
Collaborator

@Siegrift Siegrift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed my mind on how I like the looks of it, but approving. Once you fix this request review from Burak as he's responsible for the dApp's part of docs.

@acenolaza acenolaza requested a review from bbenligiray July 22, 2025 13:03
@acenolaza acenolaza merged commit 0c856cf into main Jul 23, 2025
3 checks passed
@acenolaza acenolaza deleted the data-feed-proxy-combinators branch July 23, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document in Api3 docs
3 participants