-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In support of Airnode 0.14 #705
Conversation
Visit the preview URL for this PR (updated for commit f3dde49): https://vitepress-docs--pr705-698-airnode-release-vz5jbl9n.web.app (expires Thu, 01 Feb 2024 11:36:42 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: e4c5db1acb62b36273dc03718b86834917dea599 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very thorough, nice 👍 and only very minor comments.
I wonder if it wouldn't have been partially easier, instead of "copying" the files to the new versioned folder, to git mv
the /latest
directory to /v0.13
. This way git (and GitHub) may be able to better track the history of the files and the diff might just show up as a rename rather than an entire new branch within the directory tree. Obviously too late now, but perhaps for the next version?
docs/dev/versioning.md
Outdated
| /reference/airnode/v0.11 | v0.11 | | ||
| /reference/airnode/next | v0.15 | | ||
| /reference/airnode/latest | v0.14 | | ||
| /reference/airnode/v0.11 | v0.13 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nit
| /reference/airnode/v0.11 | v0.13 | | |
| /reference/airnode/v0.13 | v0.13 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
docs/dev/versioning.md
Outdated
1. Create a new folder `/next` as a copy of `/latest` "**after**" completing the | ||
updates below to the newly renamed `/latest` and `vx.xx`. Then follow the | ||
below steps again for the new `/next`. | ||
1. Rename the `/latest` folder to `v0.14`, now an older version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't /latest
have been renamed to v0.13
in this case? Anyway, this could probably generalized to "Rename the /latest
folder to the version that is being superseded vX.YZ
"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
docs/reference/ois/next/versions.md
Outdated
@@ -25,7 +25,7 @@ deploying. | |||
| Airnode version | Latest compatible OIS version | | |||
| ------------------- | -------------------------------------------- | | |||
| Pending | 2.4.0 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have a 2.4.0
planned or in progress at the moment so I'd delete this line (i.e. the next version could be 3.0.0
or 2.3.2
, we don't know yet)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Airnode 0.14 is now latest.
There are a few broken external links:
exporerURLs
. I will report this later today after upgrading Centurion V2 and getting a copy of the output