Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In support of Airnode 0.14 #705

Merged
merged 4 commits into from
Jan 25, 2024
Merged

In support of Airnode 0.14 #705

merged 4 commits into from
Jan 25, 2024

Conversation

wkande
Copy link
Member

@wkande wkande commented Jan 23, 2024

Airnode 0.14 is now latest.

There are a few broken external links:

  1. https://community.optimism.io/docs/developers/build/transaction-fees/#displaying-fees-to-users. See here
  2. Also there are a few broken links coming from @api3/[email protected], Arbitrum exporerURLs. I will report this later today after upgrading Centurion V2 and getting a copy of the output

@wkande wkande self-assigned this Jan 23, 2024
Copy link
Contributor

github-actions bot commented Jan 23, 2024

Visit the preview URL for this PR (updated for commit f3dde49):

https://vitepress-docs--pr705-698-airnode-release-vz5jbl9n.web.app

(expires Thu, 01 Feb 2024 11:36:42 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e4c5db1acb62b36273dc03718b86834917dea599

@dcroote dcroote linked an issue Jan 23, 2024 that may be closed by this pull request
@wkande wkande requested a review from dcroote January 23, 2024 18:01
Copy link
Collaborator

@dcroote dcroote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very thorough, nice 👍 and only very minor comments.

I wonder if it wouldn't have been partially easier, instead of "copying" the files to the new versioned folder, to git mv the /latest directory to /v0.13. This way git (and GitHub) may be able to better track the history of the files and the diff might just show up as a rename rather than an entire new branch within the directory tree. Obviously too late now, but perhaps for the next version?

| /reference/airnode/v0.11 | v0.11 |
| /reference/airnode/next | v0.15 |
| /reference/airnode/latest | v0.14 |
| /reference/airnode/v0.11 | v0.13 |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nit

Suggested change
| /reference/airnode/v0.11 | v0.13 |
| /reference/airnode/v0.13 | v0.13 |

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

1. Create a new folder `/next` as a copy of `/latest` "**after**" completing the
updates below to the newly renamed `/latest` and `vx.xx`. Then follow the
below steps again for the new `/next`.
1. Rename the `/latest` folder to `v0.14`, now an older version.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't /latest have been renamed to v0.13 in this case? Anyway, this could probably generalized to "Rename the /latest folder to the version that is being superseded vX.YZ"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@@ -25,7 +25,7 @@ deploying.
| Airnode version | Latest compatible OIS version |
| ------------------- | -------------------------------------------- |
| Pending | 2.4.0 |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have a 2.4.0 planned or in progress at the moment so I'd delete this line (i.e. the next version could be 3.0.0 or 2.3.2, we don't know yet)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@wkande wkande merged commit 6c3fcfa into main Jan 25, 2024
2 checks passed
@wkande wkande deleted the 698-airnode-release-0.14 branch January 25, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs Airnode v0.14 release
2 participants