fix: Use appropriate timeouts #704
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
janbuchar
commented
Jun 9, 2025
janbuchar
commented
- closes Refactor client timeouts - parity with Python implemenation #685
- modelled after refactor: Rework client timeout apify-client-python#384
janbuchar
added
the
t-tooling
github-actions
bot
added
the
tested
B4nan
reviewed
Jun 10, 2025
barjin
requested changes
Jun 10, 2025
|
Sorry for the confusion around secs/millis - I changed my approach when working on this and stopped when the client_timeouts test started to pass 🤦 |
barjin
approved these changes
Jun 10, 2025
B4nan
reviewed
Jun 10, 2025
| /** | ||
| * Resource client. | ||
| * @private | ||
| */ | ||
| export class ResourceClient extends ApiClient { | ||
| protected async _get<T, R>(options: T = {} as T): Promise<R | undefined> { | ||
| protected async _get<T, R>(options: T = {} as T, timeoutSecs?: number): Promise<R | undefined> { |
There was a problem hiding this comment.
wouldnt it be cleaner if we keep everything in milliseconds here? its kinda low level, not really a public API where we would want to have the seconds for convenience.
There was a problem hiding this comment.
ApifyClient and HttpClient already accept timeoutSecs, so I'm afraid that ship has sailed... But you have a good point that these methods are only used internally, so it would make the internals of the resource clients a bit more uniform.
B4nan
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.