Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Check whether version in PR is already released #157

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

fnesveda
Copy link
Member

We have a recurring issue that you often forget to bump the package version number in a PR, and then when you merge it to master, the package publication fails because the version you're trying to publish already exists.

This adds a check to CI which detects these issues early and fails the CI, so you can't merge those PRs without bumping the package version number.

It gets skipped if the title of the PR is docs: ..., because such PRs don't trigger package publication when merged.

Same as apify/apify-sdk-python#127.

@fnesveda fnesveda added adhoc Ad-hoc unplanned task added during the sprint. t-platform Issues with this label are in the ownership of the platform team. labels Oct 25, 2023
@fnesveda fnesveda added this to the 75th sprint - Platform team milestone Oct 25, 2023
@fnesveda fnesveda requested a review from vdusek October 25, 2023 08:04
@fnesveda fnesveda self-assigned this Oct 25, 2023
Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fnesveda fnesveda merged commit 5216c7c into master Oct 25, 2023
@fnesveda fnesveda deleted the chore/check-for-unreleased-version-in-ci branch October 25, 2023 08:21
@drobnikj drobnikj added the validated Issues that are resolved and their solutions fulfill the acceptance criteria. label Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adhoc Ad-hoc unplanned task added during the sprint. t-platform Issues with this label are in the ownership of the platform team. validated Issues that are resolved and their solutions fulfill the acceptance criteria.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants