Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Redoc legacy urls and a script for traversing and safe dumping the yamls #1372

Merged
merged 6 commits into from
Jan 7, 2025
Merged

feat: add Redoc legacy urls and a script for traversing and safe dumping the yamls #1372

merged 6 commits into from
Jan 7, 2025

Conversation

netmilk
Copy link
Contributor

@netmilk netmilk commented Jan 3, 2025

No description provided.

@netmilk netmilk requested a review from B4nan January 3, 2025 11:51
B4nan
B4nan reviewed Jan 3, 2025
View reviewed changes
Copy link
Member

@B4nan B4nan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, should we get rid of the https://docs.apify.com/api/v2 prefix everywhere? the redirection script I build doesn't need it, and I can imagine the decorators also don't, looking at their code, they just cut the part before the # sign

apify-api/openapi/components/tags.yaml Outdated Show resolved Hide resolved
@B4nan B4nan changed the title Added Redoc legacy urls and a script for traversing and safe dumping the yamls feat: add Redoc legacy urls and a script for traversing and safe dumping the yamls Jan 3, 2025
@netmilk netmilk force-pushed the chore/netmilk/redoc-legacy-urls branch from 5e6eb2b to 51d139e Compare January 7, 2025 13:09
B4nan
B4nan approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@B4nan B4nan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few nits about the scripts, nothing blocking, checked a few URLs and all good

apify-api/scripts/add-redoc-legacy-urls-to-tags.py Outdated Show resolved Hide resolved
apify-api/scripts/add-redoc-legacy-urls-to-tags.py Outdated Show resolved Hide resolved
apify-api/scripts/add-redoc-legacy-urls-to-tags.py Show resolved Hide resolved
apify-api/scripts/add-redoc-legacy-urls-to-tags.py Show resolved Hide resolved
apify-api/scripts/add-redoc-legacy-urls-to-operations.py Outdated Show resolved Hide resolved
apify-api/scripts/add-redoc-legacy-urls-to-operations.py Outdated Show resolved Hide resolved
@netmilk netmilk merged commit 865d70d into master Jan 7, 2025
8 checks passed
@netmilk netmilk deleted the chore/netmilk/redoc-legacy-urls branch January 7, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@B4nan B4nan B4nan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@netmilk @B4nan