Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add note about checking for existing type key #1381

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

webchick
Copy link
Contributor

@webchick webchick commented Jan 7, 2025

Note: There are multiple ways we could go about updating the text, but this seemed the least invasive for now.

Closes #1380

@webchick webchick requested a review from honzajavorek as a code owner January 7, 2025 14:43
@webchick
Copy link
Contributor Author

webchick commented Jan 7, 2025

Note: I'm not normally this pedantic (oh, who am I kidding? 🤣 ), but since this course is aimed at beginner-level programmers, it's possible someone just starting out with Node / VS Code could get tripped up by this.

@B4nan
Copy link
Member

B4nan commented Jan 7, 2025

no worries, we like attention to detail, and since you are fine with sending PRs yourself, its actually highly appreciated :]

@B4nan B4nan merged commit fe3e7ec into apify:master Jan 7, 2025
5 of 8 checks passed
@honzajavorek
Copy link
Collaborator

Thanks for improving the course!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"type": "commonjs" is now the default in npm init
3 participants