-
Notifications
You must be signed in to change notification settings - Fork 98
docs: Prepare docs for fileupload editor #1524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
See apify/apify-shared-js#509 for the final name of the editor |
We want to add file upload to the input schema, decided to go with url on the input. Seems like a good idea to just use a special editor for this, instead of adding a new input type. The default fallback editor should work reasonably well everywhere. ### Related PRs: - apify/apify-docs#1524
Example of file selection using `fileupload` editor. The input is passed to the Actor as a string, it is up to the author to resolve the file or validate if it exists. | ||
|
||
 | ||
|
||
|
||
The input allows the user to either provide a link or to upload the file as a record to a key-value store of their choosing. | ||
|
||
 | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example of file selection using `fileupload` editor. The input is passed to the Actor as a string, it is up to the author to resolve the file or validate if it exists. | |
 | |
The input allows the user to either provide a link or to upload the file as a record to a key-value store of their choosing. | |
 | |
The `fileupload` editor enables users to specify a file as input. The input is passed to the Actor as a string. It is the author's responsibility to interpret this string, including validation of its existence and format. | |
 | |
It could be a URL or a key-value store record identifier and manage the file content. | |
 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I'm not sure about this phrase:
It could be a URL or a key-value store record identifier and manage the file content.
I was trying to explain that the UI makes it easier for users to upload a file to a key-value store, and that they can choose an existing store, or create a new one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, yeah I might have went a little overboard with this one, and create more confusion where it wasn't needed.
Let's go with something closer to original just slightly rephrased to avoid words like lets
The user provides either a URL or uploads the file to a key-value store (existing or new)."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one question, which may turn into further edit :D
@@ -223,11 +223,19 @@ The `anyDate` property renders a date picker that accepts both absolute and rela | |||
|
|||
 | |||
|
|||
The `fileupload` editor enables users to specify a file as input. The input is passed to the Actor as a string. It is the author's responsibility to interpret this string, including validation of its existence and format. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question to clarify, does this mean Actor's author? or the Actor user? Reading it back now it's not entirely clear, maybe there is a better wording for this as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's easier for Actor user to provide a link to a file.
The Actor's author needs to deal with a string, that 🤞 , should be a link to a file. But it's the author's responsibility to check this (and handle the case when it's not).
Does that make sense?
This PR should be merged once the feature is in Apify Console.
Related PRs