Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update usage and resources #886
docs: update usage and resources #886
Changes from 2 commits
3ca671b
a762092
55cfbaf
29b6461
d8311f5
05eed3f
e74aeab
ef23f9a
2516d68
a534b2a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 16 in sources/platform/actors/running/usage_and_resources.md
GitHub Actions / vale
[vale] sources/platform/actors/running/usage_and_resources.md#L16
Raw output
Check warning on line 29 in sources/platform/actors/running/usage_and_resources.md
GitHub Actions / vale
[vale] sources/platform/actors/running/usage_and_resources.md#L29
Raw output
Check warning on line 30 in sources/platform/actors/running/usage_and_resources.md
GitHub Actions / vale
[vale] sources/platform/actors/running/usage_and_resources.md#L30
Raw output
Check warning on line 33 in sources/platform/actors/running/usage_and_resources.md
GitHub Actions / vale
[vale] sources/platform/actors/running/usage_and_resources.md#L33
Raw output
Check warning on line 40 in sources/platform/actors/running/usage_and_resources.md
GitHub Actions / vale
[vale] sources/platform/actors/running/usage_and_resources.md#L40
Raw output
Check warning on line 40 in sources/platform/actors/running/usage_and_resources.md
GitHub Actions / vale
[vale] sources/platform/actors/running/usage_and_resources.md#L40
Raw output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be checked with someone from delivery / tooling. Not sure if this is 100% true, as it contradicts a bit the cheerio section later (with mention of node threads)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@B4nan could we get some input here and in other issues mentioned by @valekjo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it feels correct. 4g memory = 1cpu core, so the note about max memory of 4g for cheerio makes sense, the node process will only use a single thread there (sidenote: that's how we have it implemented, we could try to leverage worker threads or other similar parallelization features of node to get around this).
cc @metalwarrior665 for field experience :]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, 4 GB is a target for non-browser Node.js actors because of the single core restriction.
Also, Apify SDK doesn't use any autoscaling, there is nothing to scale there, that is only related to Crawlee.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, as I understand, mention of Apify JS SDK should be removed from this paragraph, as it is only regarding Crawlee?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep.
Check warning on line 67 in sources/platform/actors/running/usage_and_resources.md
GitHub Actions / vale
[vale] sources/platform/actors/running/usage_and_resources.md#L67
Raw output
Check warning on line 86 in sources/platform/actors/running/usage_and_resources.md
GitHub Actions / vale
[vale] sources/platform/actors/running/usage_and_resources.md#L86
Raw output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be better to be discussed with tooling / delivery.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine. The idea is that for a browser actor to start scaling concurrency, 1 GB is just not very useful but it can work as a minimum
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd change the link to somehting else - it's quite old and at the referenced site you have to create account to read it.
I'd again discuss with tooling / delivery which would be the nice articles to refer to. (I also mean the next one on multiple threads)
Check warning on line 100 in sources/platform/actors/running/usage_and_resources.md
GitHub Actions / vale
[vale] sources/platform/actors/running/usage_and_resources.md#L100
Raw output
Check warning on line 100 in sources/platform/actors/running/usage_and_resources.md
GitHub Actions / vale
[vale] sources/platform/actors/running/usage_and_resources.md#L100
Raw output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd add some info where to find the run usage - it's visible on run detail and in run list.
Check warning on line 118 in sources/platform/actors/running/usage_and_resources.md
GitHub Actions / vale
[vale] sources/platform/actors/running/usage_and_resources.md#L118
Raw output
Check warning on line 119 in sources/platform/actors/running/usage_and_resources.md
GitHub Actions / vale
[vale] sources/platform/actors/running/usage_and_resources.md#L119
Raw output
Check warning on line 119 in sources/platform/actors/running/usage_and_resources.md
GitHub Actions / vale
[vale] sources/platform/actors/running/usage_and_resources.md#L119
Raw output
Check warning on line 125 in sources/platform/actors/running/usage_and_resources.md
GitHub Actions / vale
[vale] sources/platform/actors/running/usage_and_resources.md#L125
Raw output
Check warning on line 127 in sources/platform/actors/running/usage_and_resources.md
GitHub Actions / vale
[vale] sources/platform/actors/running/usage_and_resources.md#L127
Raw output
Check warning on line 139 in sources/platform/actors/running/usage_and_resources.md
GitHub Actions / vale
[vale] sources/platform/actors/running/usage_and_resources.md#L139
Raw output
Check warning on line 142 in sources/platform/actors/running/usage_and_resources.md
GitHub Actions / vale
[vale] sources/platform/actors/running/usage_and_resources.md#L142
Raw output
Check warning on line 142 in sources/platform/actors/running/usage_and_resources.md
GitHub Actions / vale
[vale] sources/platform/actors/running/usage_and_resources.md#L142
Raw output
Check warning on line 152 in sources/platform/actors/running/usage_and_resources.md
GitHub Actions / vale
[vale] sources/platform/actors/running/usage_and_resources.md#L152
Raw output