Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: support got-scraping v4 #233

Merged
merged 8 commits into from
Nov 27, 2023
Merged

chore: support got-scraping v4 #233

merged 8 commits into from
Nov 27, 2023

Conversation

vladfrangu
Copy link
Member

@vladfrangu vladfrangu commented Oct 3, 2023 •
edited
Loading

@github-actions github-actions bot added this to the 73nd sprint - Tooling team milestone Oct 3, 2023
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Oct 3, 2023
@vladfrangu vladfrangu added the adhoc Ad-hoc unplanned task added during the sprint. label Oct 3, 2023
@vladfrangu vladfrangu requested a review from B4nan October 3, 2023 15:31
@vladfrangu
Copy link
Member Author

@B4nan SIGSEGV on tests, looks like we need to move this repo to vitest too 😄 😢

@vladfrangu vladfrangu mentioned this pull request Nov 20, 2023
Merged
@github-actions github-actions bot added the tested Temporary label used only programatically for some analytics. label Nov 20, 2023
B4nan pushed a commit to apify/apify-shared-js that referenced this pull request Nov 22, 2023
@vladfrangu
fix(input_secrets): fix ESM build (#423)
bec8a96 
Needed for apify/apify-sdk-js#233

![Code - 2023-11-20 at 23 22
45](https://github.com/apify/apify-shared-js/assets/17960496/8099ce2d-d8ff-4629-9480-997bc05eadf3)
@B4nan B4nan merged commit 661192a into master Nov 27, 2023
8 checks passed
@B4nan B4nan deleted the feat/got-scraping-v4 branch November 27, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@B4nan B4nan B4nan approved these changes

@jancurn jancurn Awaiting requested review from jancurn

@mnmkng mnmkng Awaiting requested review from mnmkng

Assignees

@vladfrangu vladfrangu

Labels
adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.
Projects
None yet
Milestone
73nd sprint - Tooling team
Development

Successfully merging this pull request may close these issues.
2 participants
@vladfrangu @B4nan