Skip to content

Commit

Permalink
Update log integration tests after logging change on platform (#111)
Browse files Browse the repository at this point in the history
We're changing the logging during Actor startup to also include the
build ID, and this change would break the log test. This adjusts the
test so that it won't fail when the platform change is released.
  • Loading branch information
fnesveda authored Aug 31, 2023
1 parent 2482336 commit 3acb8ba
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 2 deletions.
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
Changelog
=========

[1.1.4](../../releases/tag/v1.1.4) - Unreleased
-----------------------------------------------

### Internal changes

- Fixed integration tests for Actor logger


[1.1.3](../../releases/tag/v1.1.3) - 2023-08-25
-----------------------------------------------

Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[project]
name = "apify"
version = "1.1.3"
version = "1.1.4"
description = "Apify SDK for Python"
readme = "README.md"
license = {text = "Apache Software License"}
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/test_actor_log.py
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ async def main() -> None:
run_log_lines = [line[25:] for line in run_log_lines]

# This might be way too specific and easy to break, but let's hope not
assert run_log_lines.pop(0) == 'ACTOR: Pulling Docker image from repository.'
assert run_log_lines.pop(0).startswith('ACTOR: Pulling Docker image')
assert run_log_lines.pop(0) == 'ACTOR: Creating Docker container.'
assert run_log_lines.pop(0) == 'ACTOR: Starting Docker container.'
assert run_log_lines.pop(0) == 'INFO Initializing actor...'
Expand Down

0 comments on commit 3acb8ba

Please sign in to comment.