Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Python 3.12 #121

Merged
merged 3 commits into from
Oct 23, 2023
Merged

Add support for Python 3.12 #121

merged 3 commits into from
Oct 23, 2023

Conversation

vdusek
Copy link
Contributor

@vdusek vdusek commented Oct 10, 2023

@github-actions github-actions bot added this to the 74nd sprint - Tooling team milestone Oct 10, 2023
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Oct 10, 2023
@vdusek vdusek marked this pull request as draft October 10, 2023 07:51
@github-actions github-actions bot added the tested Temporary label used only programatically for some analytics. label Oct 10, 2023
@vdusek vdusek force-pushed the add-support-py312 branch 3 times, most recently from a884003 to c07d0ba Compare October 10, 2023 14:48
@vdusek
Copy link
Contributor Author

vdusek commented Oct 10, 2023

Blocked by jfhbrook/pyee#134.

@vdusek vdusek force-pushed the add-support-py312 branch 3 times, most recently from c0031c4 to 9a37553 Compare October 17, 2023 12:53
@vdusek vdusek marked this pull request as ready for review October 17, 2023 12:53
@vdusek vdusek requested a review from jirimoravcik October 17, 2023 12:53
@vdusek vdusek removed the request for review from jirimoravcik October 17, 2023 13:25
@vdusek
Copy link
Contributor Author

vdusek commented Oct 17, 2023 •
edited
Loading

Integration tests for Python3.12:

ACTOR: ERROR: Docker image build failed: manifest for apify/actor-python:3.12 not found: manifest unknown: manifest unknown

First, merge apify/apify-actor-docker#112 and release new base images.

@vdusek vdusek force-pushed the add-support-py312 branch from 9a37553 to 95f3495 Compare October 18, 2023 15:55
@vdusek vdusek force-pushed the add-support-py312 branch from 647358d to eca6b3a Compare October 23, 2023 08:29
@vdusek
Copy link
Contributor Author

vdusek commented Oct 23, 2023

Okay, so at first we will need to merge this PR and release a new version of Apify Python SDK.

Then we would need to update the SDK version in the apify/apify-actor-docker#112, merge it, and release new Docker images for Python 3.12.

And then, finally, we can add Python 3.12 here.

@vdusek vdusek requested a review from jirimoravcik October 23, 2023 08:36
@vdusek vdusek merged commit 2678dca into master Oct 23, 2023
@vdusek vdusek deleted the add-support-py312 branch October 23, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jirimoravcik jirimoravcik jirimoravcik approved these changes

Assignees

@vdusek vdusek

Labels
t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.
Projects
None yet
Milestone
74nd sprint - Tooling team
Development

Successfully merging this pull request may close these issues.
2 participants
@vdusek @jirimoravcik