Migrate from Flake8 & Autopep8 to Ruff #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
t-tooling
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request is neither linked to an issue or epic nor labeled as adhoc!
vdusek
changed the title
There was a problem hiding this comment.
Pull request is neither linked to an issue or epic nor labeled as adhoc!
There was a problem hiding this comment.
Pull request is neither linked to an issue or epic nor labeled as adhoc!
vdusek
force-pushed
the
add-ruff
branch
10 times, most recently
from
0028d34 to
8a96a38
Compare
|
pls replace |
jirimoravcik
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ruff formatandruff check --fix.Anywith generic types #138Dataset._get_data_internal()crawlee-python#455uniqueKeygeneration logic #141RequestQueue._ensure_head_is_non_emptycrawlee-python#174update_request()calls inRequestQueue.reclaim_request()crawlee-python#424APIFY_DEFAULT_XXX_IDenv var inBaseResourceClient#149Issues
Problem with
typing.get_type_hints()typing.get_type_hints()throws an error if|is used in the type hint, even iffrom __future__ import annotationsis used.